X-Git-Url: http://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Ftools.c;h=0a29ddf8e64cce7875a8a9d8c8fe37a0c6d90a13;hp=09cc3d3a17b362b324b99d5ef20fc922d885ff36;hb=6bc8ea012391198bc3898ae2937558b60dd55906;hpb=caf366998b97b7cc29bc1f33c285feb2f5d33bff diff --git a/tools/tools.c b/tools/tools.c index 09cc3d3a..0a29ddf8 100644 --- a/tools/tools.c +++ b/tools/tools.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -15,6 +16,7 @@ #include #include #include +#include #include "tools.h" static const char *tmpdir = NULL; @@ -71,7 +73,7 @@ char *run_with_timeout(const void *ctx, const char *cmd, int p[2]; char *ret; int status, ms; - struct timeval start, end; + struct timeval start; *ok = false; if (pipe(p) != 0) @@ -83,7 +85,7 @@ char *run_with_timeout(const void *ctx, const char *cmd, /* Always flush buffers before fork! */ fflush(stdout); - gettimeofday(&start, NULL); + start = time_now(); pid = fork(); if (pid == -1) { close_noerr(p[0]); @@ -105,8 +107,7 @@ char *run_with_timeout(const void *ctx, const char *cmd, signal(SIGALRM, killme); itim.it_interval.tv_sec = itim.it_interval.tv_usec = 0; - itim.it_value.tv_sec = *timeout_ms / 1000; - itim.it_value.tv_usec = (*timeout_ms % 1000) * 1000; + itim.it_value = time_from_msec(*timeout_ms); setitimer(ITIMER_REAL, &itim, NULL); status = system(cmd); @@ -122,13 +123,7 @@ char *run_with_timeout(const void *ctx, const char *cmd, if (waitpid(pid, &status, 0) != pid) err(1, "Failed to wait for child"); - gettimeofday(&end, NULL); - if (end.tv_usec < start.tv_usec) { - end.tv_usec += 1000000; - end.tv_sec--; - } - ms = (end.tv_sec - start.tv_sec) * 1000 - + (end.tv_usec - start.tv_usec) / 1000; + ms = time_to_msec(time_sub(time_now(), start)); if (ms > *timeout_ms) *timeout_ms = 0; else