X-Git-Url: http://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Ftests_exist.c;h=86f7ef27e816e902c406c2a92aec44dba26a20dc;hp=bdfe49d56b8725389b279671052fd8356f499a06;hb=db43894721895d0ec0a8e599440a9897136bfcb6;hpb=051db34fb275491d4d5dfa5bf7970e8e525766d8

diff --git a/tools/ccanlint/tests/tests_exist.c b/tools/ccanlint/tests/tests_exist.c
index bdfe49d5..86f7ef27 100644
--- a/tools/ccanlint/tests/tests_exist.c
+++ b/tools/ccanlint/tests/tests_exist.c
@@ -10,7 +10,7 @@
 #include <err.h>
 #include <ccan/talloc/talloc.h>
 
-extern struct ccanlint tests_exist;
+REGISTER_TEST(tests_exist);
 
 static void handle_no_tests(struct manifest *m, struct score *score)
 {
@@ -100,7 +100,7 @@ static void check_tests_exist(struct manifest *m,
 	char *test_dir = talloc_asprintf(m, "%s/test", m->dir);
 
 	if (lstat(test_dir, &st) != 0) {
-		score->error = "No test directory";
+		score->error = talloc_strdup(score, "No test directory");
 		if (errno != ENOENT)
 			err(1, "statting %s", test_dir);
 		tests_exist.handle = handle_no_tests;
@@ -108,7 +108,7 @@ static void check_tests_exist(struct manifest *m,
 	}
 
 	if (!S_ISDIR(st.st_mode)) {
-		score->error = "test is not a directory";
+		score->error = talloc_strdup(score, "test is not a directory");
 		return;
 	}
 
@@ -116,10 +116,12 @@ static void check_tests_exist(struct manifest *m,
 	    && list_empty(&m->run_tests)
 	    && list_empty(&m->compile_ok_tests)) {
 		if (list_empty(&m->compile_fail_tests)) {
-			score->error = "No tests in test directory";
+			score->error = talloc_strdup(score,
+					     "No tests in test directory");
 			tests_exist.handle = handle_no_tests;
 		} else
-			score->error = "No positive tests in test directory";
+			score->error = talloc_strdup(score,
+				     "No positive tests in test directory");
 		return;
 	}
 	score->pass = true;
@@ -133,4 +135,3 @@ struct ccanlint tests_exist = {
 	.needs = ""
 };
 
-REGISTER_TEST(tests_exist);