X-Git-Url: http://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Flicense_exists.c;h=3482bfee7745d6913a76380e8648a18695e62d65;hp=dbfe29b5d7e450498c881a98dca6e81eb7ffc2bf;hb=HEAD;hpb=f826598e1f39c723cca1e6955b50b19f14b23538 diff --git a/tools/ccanlint/tests/license_exists.c b/tools/ccanlint/tests/license_exists.c index dbfe29b5..3482bfee 100644 --- a/tools/ccanlint/tests/license_exists.c +++ b/tools/ccanlint/tests/license_exists.c @@ -1,4 +1,7 @@ #include +#include +#include +#include #include #include #include @@ -8,106 +11,80 @@ #include #include #include -#include #include -#include +#include -static struct doc_section *find_license_tag(const struct manifest *m) +/* We might need more ../ for nested modules. */ +static const char *link_prefix(struct manifest *m) { - struct doc_section *d; + char *prefix = tal_strdup(m, "../../"); + unsigned int i; - list_for_each(m->info_file->doc_sections, d, list) { - if (!streq(d->function, m->basename)) - continue; - if (streq(d->type, "license")) - return d; - } - return NULL; -} + for (i = 0; i < strcount(m->modname, "/"); i++) + prefix = tal_strcat(m, take(prefix), "../"); -/* See GPLv2 and v2 (basically same wording) for interpreting versions: - * the "any later version" means the recepient can choose. */ -static enum license which_license(struct doc_section *d) -{ - /* This means "user chooses what version", including GPLv1! */ - if (streq(d->lines[0], "GPL")) - return LICENSE_GPL; - /* This means "v2 only". */ - if (streq(d->lines[0], "GPLv2")) - return LICENSE_GPLv2; - /* This means "v2 or above" at user's choice. */ - if (streq(d->lines[0], "GPL (v2 or any later version)")) - return LICENSE_GPLv2_PLUS; - /* This means "v3 or above" at user's choice. */ - if (streq(d->lines[0], "GPL (v3 or any later version)")) - return LICENSE_GPLv3; - - /* This means "user chooses what version" */ - if (streq(d->lines[0], "LGPL")) - return LICENSE_LGPL; - /* This means "v2.1 only". */ - if (streq(d->lines[0], "LGPLv2.1")) - return LICENSE_LGPLv2; - /* This means "v2.1 or above" at user's choice. */ - if (streq(d->lines[0], "LGPL (v2.1 or any later version)")) - return LICENSE_LGPLv2_PLUS; - /* This means "v3 or above" at user's choice. */ - if (streq(d->lines[0], "LGPL (v3 or any later version)")) - return LICENSE_LGPLv3; - - if (streq(d->lines[0], "BSD-MIT") || streq(d->lines[0], "MIT")) - return LICENSE_MIT; - if (streq(d->lines[0], "BSD (3 clause)")) - return LICENSE_BSD; - if (strreg(NULL, d->lines[0], "[Pp]ublic [Dd]omain")) - return LICENSE_PUBLIC_DOMAIN; - - return LICENSE_UNKNOWN; + return tal_strcat(m, take(prefix), "licenses/"); } -static const char *expected_link(enum license license) +static const char *expected_link(const tal_t *ctx, + const char *prefix, enum license license) { + const char *shortname; + switch (license) { case LICENSE_LGPLv2_PLUS: case LICENSE_LGPLv2: - return "../../licenses/LGPL-2.1"; + shortname = "LGPL-2.1"; + break; case LICENSE_LGPLv3: case LICENSE_LGPL: - return "../../licenses/LGPL-3"; + shortname = "LGPL-3"; + break; case LICENSE_GPLv2_PLUS: case LICENSE_GPLv2: - return "../../licenses/GPL-2"; + shortname = "GPL-2"; + break; case LICENSE_GPLv3: case LICENSE_GPL: - return "../../licenses/GPL-3"; + shortname = "GPL-3"; + break; case LICENSE_BSD: - return "../../licenses/BSD-3CLAUSE"; + shortname = "BSD-3CLAUSE"; + break; case LICENSE_MIT: - return "../../licenses/BSD-MIT"; + shortname = "BSD-MIT"; + break; + + case LICENSE_CC0: + shortname = "CC0"; + break; default: return NULL; } + + return tal_strcat(ctx, prefix, shortname); } static void handle_license_link(struct manifest *m, struct score *score) { struct doc_section *d = find_license_tag(m); - const char *link = talloc_asprintf(m, "%s/LICENSE", m->dir); - const char *ldest = expected_link(m->license); + const char *prefix = link_prefix(m); + const char *link = path_join(m, m->dir, "LICENSE"); + const char *ldest = expected_link(score, prefix, m->license); char *q; printf( "Most modules want a copy of their license, so usually we create a\n" - "LICENSE symlink into ../../licenses to avoid too many copies.\n"); + "LICENSE symlink into %s to avoid too many copies.\n", prefix); /* FIXME: make ask printf-like */ - q = talloc_asprintf(m, "Set up link to %s (license is %s)?", - ldest, d->lines[0]); + q = tal_fmt(m, "Set up link to %s (license is %s)?", + ldest, d->lines[0]); if (ask(q)) { if (symlink(ldest, link) != 0) err(1, "Creating symlink %s -> %s", link, ldest); @@ -117,18 +94,19 @@ static void handle_license_link(struct manifest *m, struct score *score) extern struct ccanlint license_exists; static void check_has_license(struct manifest *m, - bool keep, - unsigned int *timeleft, struct score *score) + unsigned int *timeleft UNNEEDED, + struct score *score) { char buf[PATH_MAX]; ssize_t len; - char *license = talloc_asprintf(m, "%s/LICENSE", m->dir); + char *license = path_join(m, m->dir, "LICENSE"); const char *expected; struct doc_section *d; + const char *prefix = link_prefix(m); d = find_license_tag(m); if (!d) { - score->error = talloc_strdup(score, "No License: tag in _info"); + score->error = tal_strdup(score, "No License: tag in _info"); return; } @@ -145,7 +123,7 @@ static void check_has_license(struct manifest *m, /* If they have a license tag at all, we pass. */ score->pass = true; - expected = expected_link(m->license); + expected = expected_link(m, prefix, m->license); len = readlink(license, buf, sizeof(buf)); if (len < 0) { @@ -156,7 +134,7 @@ static void check_has_license(struct manifest *m, return; } score->error - = talloc_asprintf(score, + = tal_fmt(score, "License in _info is '%s'," " expect LICENSE symlink '%s'", d->lines[0], expected); @@ -168,7 +146,7 @@ static void check_has_license(struct manifest *m, score->score = score->total; return; } - score->error = talloc_strdup(score, + score->error = tal_strdup(score, "LICENSE does not exist"); if (expected) license_exists.handle = handle_license_link; @@ -181,24 +159,23 @@ static void check_has_license(struct manifest *m, buf[len] = '\0'; - if (!strstarts(buf, "../../licenses/")) { - score->error = talloc_asprintf(score, - "Expected symlink to" - " ../../licenses/..." - " not %s", buf); + if (!strstarts(buf, prefix)) { + score->error = tal_fmt(score, + "Expected symlink into %s not %s", + prefix, buf); return; } if (!expected) { - score->error = talloc_asprintf(score, - "License in _info is unknown '%s'," - " but LICENSE symlink is '%s'", - d->lines[0], buf); + score->error = tal_fmt(score, + "License in _info is unknown '%s'," + " but LICENSE symlink is '%s'", + d->lines[0], buf); return; } if (!streq(buf, expected)) { - score->error = talloc_asprintf(score, + score->error = tal_fmt(score, "Expected symlink to %s not %s", expected, buf); return;