ccanlint: don't fail just because we don't have positive tests.

[ccan] / tools / ccanlint / tests / tests_coverage.c

diff --git a/tools/ccanlint/tests/tests_coverage.c b/tools/ccanlint/tests/tests_coverage.c
index a2b9ee32cf6d0ec421db8aa050a63332b82f829a..a8da103f045fed21280625a1bbf9c4c4e44814c8 100644 (file)
--- a/tools/ccanlint/tests/tests_coverage.c
+++ b/tools/ccanlint/tests/tests_coverage.c
@@ -110,6 +110,10 @@ static void analyze_coverage(struct manifest *m, bool full_gcov,
 
        score->pass = true;
 
+       if (verbose > 1)
+               printf("%u of %u lines covered\n",
+                      (unsigned)covered_lines, total_lines);
+
        /* Nothing covered?  We can't tell if there's a source file which
         * was never executed, or there really is no code to execute, so
         * assume the latter: this test deserves no score. */
@@ -131,6 +135,7 @@ static void do_run_coverage_tests(struct manifest *m,
        char *covcmd;
        bool full_gcov = (verbose > 1);
        struct list_head *list;
+       bool ran_some = false;
 
        /* This tells gcov where we put those .gcno files. */
        outdir = talloc_dirname(score, m->info_file->compiled);
@@ -161,9 +166,17 @@ static void do_run_coverage_tests(struct manifest *m,
                                                 " failed: %s", cmdout);
                                return;
                        }
+                       ran_some = true;
                }
        }
 
+       /* No tests at all?  0 out of 0 for you... */
+       if (!ran_some) {
+               score->total = score->score = 0;
+               score->pass = true;
+               return;
+       }
+
        /* Now run gcov: we want output even if it succeeds. */
        if (!run_command(score, timeleft, &cmdout, "%s", covcmd)) {
                score->error = talloc_asprintf(score, "Running gcov: %s",