From 225361d64ae737afdc8cb57579a2f33525461bc9 Mon Sep 17 00:00:00 2001 From: Paul Mackerras Date: Mon, 11 Mar 2013 19:30:21 +1100 Subject: [PATCH] pppd: Default exit status to EXIT_CONNECT_FAILED during connection phase The rp-pppoe plugin doesn't set the exit status in its connect function, resulting in pppd exiting with a status of EXIT_OK (0) if rp-pppoe fails to connect. This fixes the problem for rp-pppoe and any other plugins that don't set the exit status explicitly by making the status default to EXIT_CONNECT_FAILED if the channel's connect function fails. Reported-by: Peter Warasin Signed-off-by: Paul Mackerras --- pppd/auth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pppd/auth.c b/pppd/auth.c index 2f81283..4271af6 100644 --- a/pppd/auth.c +++ b/pppd/auth.c @@ -553,6 +553,7 @@ link_required(unit) void start_link(unit) int unit; { + status = EXIT_CONNECT_FAILED; new_phase(PHASE_SERIALCONN); hungup = 0; -- 2.39.2