Rusty Russell [Thu, 1 Dec 2011 06:14:51 +0000 (16:44 +1030)]
opt: add OPT_EARLY and opt_early_parse.
Parsing options like --verbose and --debug can be a pain. You need to
have everything set up before invoking parse_args(), but that may be a
significant amount of work, for which you may want verbose or
debugging enabled.
Thus the concept of "early" args: you can nominate arguments to be
parse before anything else, using opt_early_parse().
Rusty Russell [Wed, 30 Nov 2011 01:39:18 +0000 (12:09 +1030)]
tdb2: add a capability list from the header.
This allows even more extensibility in future: in particular, the top
bits of each capability tell us what to do if we don't understand it:
fail the open, fail to open for write, or don't try to check the
format.
tdb_check needs to understand the capability list so it can know to
skip over it: each element in the list is prefixed with the type tag
and the length.
Rusty Russell [Wed, 30 Nov 2011 00:23:42 +0000 (10:53 +1030)]
failtest: save and restore file state inside child (on-demand)
We currently save all files in the parent, and restore them once
the child is gone. That doesn't work in a case where the child
manipulates a file the parent doesn't currently have open, so
switch to a model where the child cleans itself up, using the
already-existing cleanup callbacks.
This means that we need to undo much more, especially restoring
file offsets. We also need to handle the case where we've already
closed the file, and now we're cleaning up. As a bonus, we now
handle open() with O_TRUNC properly.
The cleanup function now has two modes: one simply frees (so valgrind
doesn't complain about failtest leaking so the user can see real leaks
in their programs), the other restores things so the parent sees no
changes.
Rusty Russell [Tue, 29 Nov 2011 22:41:11 +0000 (09:11 +1030)]
tdb2: simplify failtest helper.
failtest now culls duplicates for itself (and more efficiently), so
don't replicate the logic here. It changes things a bit, because
failtest uses backtraces rather than a simple call point to find
duplicates.
Also, fix one case (in run-11-simple-fetch.c) where we simply exited
rather than using failtest_exit(). We got away with it before, because
we never hit that particular failure pattern.
Rusty Russell [Tue, 29 Nov 2011 22:40:11 +0000 (09:10 +1030)]
failtest: fix --debugpath
Calling failpath_string() here leaves the final letter randomly upper or
lower-cased, since call->fail is uninitialized. This means we sometimes
don't match the debug string.
1) Initialize call->fail here so it will match the debug string.
2) If our calls don't match --debugpath, abort.
3) Don't match the final letter (which may be upper or lower case)
when checking we're still on the path. We could do better, but this is
only a sanity-check anyway.
Rusty Russell [Tue, 29 Nov 2011 22:39:11 +0000 (09:09 +1030)]
failtest: internally eliminate duplicate calls.
If we can get a backtrace, we can automatically eliminate identical
failures. Surprisingly backtrace() is quite fast, but the savings for
the (naively-written) rbtree tests are impressive. ccanlint -v time
drops from 43 seconds to 6 seconds.
Rusty Russell [Tue, 29 Nov 2011 22:37:11 +0000 (09:07 +1030)]
failtest: simplify FAIL_PROBE.
When a failtest_hook returns fail_probe(), we start a counter to
continue for a little way. Replace this hack with a simple flag,
which disables further failures.
Interestingly, this doesn't reduce coverage on the current modules
which use failtest.
Rusty Russell [Tue, 29 Nov 2011 22:35:11 +0000 (09:05 +1030)]
failtest: use high-numbers file descriptors to stay out of the way.
We use file descriptors inside failtest; use dup2 to try to avoid
changing the file descriptor numbers used in the program (particularly
when programs mess with invalid file descriptors, they're likely to
still be invalid).
Rusty Russell [Tue, 29 Nov 2011 22:30:11 +0000 (09:00 +1030)]
failtest: fix internal cut & paste bug
failtest_malloc should use p->u.malloc not p->u.calloc. The layouts
are identical, so it doesn't matter, but it's confusing and leaves us
open to weird bugs in future should one change.
Rusty Russell [Tue, 29 Nov 2011 22:29:11 +0000 (08:59 +1030)]
ccanlint: fix depends_build_without_features
This depends on reduce_features; currently it tends to run before
that, so it doesn't think there are any features to reduce and doesn't
build or run the tests with reduced features.
Rusty Russell [Tue, 15 Nov 2011 02:12:25 +0000 (12:42 +1030)]
ccanlint: make fewer tests compulsory.
Compulsory means "malformed", we might get rid of it altogether, since
any test can mark "fail" and make ccanlint exit with non-zero status.
Now we only have four compulsory tests:
info_exists Module has _info file
depends_exist Module's CCAN dependencies can be found
objects_build Module object files can be built
module_builds Module can be built from object files
Rusty Russell [Tue, 1 Nov 2011 23:38:32 +0000 (10:08 +1030)]
tdb2: don't be fascist when TDB_VERSION1 is specified.
We currently insist that a tdb file be a version1 file if tdb_open() is
passed the TDB_VERSION1 flag; we fail if it's actually a tdb2.
But that makes generic wrappers harder, and is unlikely to be what the
user wants: if they do, they can check tdb_get_flags() & TDB_VERSION1
after opening.
Rusty Russell [Tue, 1 Nov 2011 23:06:29 +0000 (09:36 +1030)]
strset: set errno to ENOENT even if we return NULL.
It seems redundant: strset_test() and strset_clear() can only return NULL
when the string is not a member. However, it became clear in writing
ccan/tsort that it's much more convenient for callers if we set errno
in this case too, so they can pass it up.
Rusty Russell [Tue, 1 Nov 2011 23:05:29 +0000 (09:35 +1030)]
strmap: set errno to ENOENT even if we return NULL.
It seems redundant: strmap_get() and strmap_del() can only return NULL
when the string is not a member. However, it became clear in writing
ccan/tsort that it's much more convenient for callers if we set errno
in this case too, so they can pass it up.
Rusty Russell [Wed, 5 Oct 2011 05:23:35 +0000 (15:53 +1030)]
ccanlint: drop -d, interpret any arguments as directories, and allow multiple.
This gets us closer to 'ccanlint *' rather than relying on Makefiles
to test all modules. Unfortunately, because of limited parallelism, it's
currently slower than make -j.
Rusty Russell [Wed, 5 Oct 2011 03:40:29 +0000 (14:10 +1030)]
ccanlint: fix spurious warning errors.
Because we fork children to do compilations, and we use stdio, we need
to flush stdout before the fork otherwise the child will flush
afterwards. The compile tests interpret this output as a compiler
warning.
This shows up if you redirect ccanlint output to a file.
Rusty Russell [Tue, 4 Oct 2011 01:40:09 +0000 (12:10 +1030)]
tdb2: fix valgrind suppression in _info.
Commit c4ca9f54301c0367 renamed run-83-openhook.c to
api-83-openhook.c, but didn't update the suppression in _info. My
system runs a patched valgrind, which doesn't have this problem.
Rusty Russell [Tue, 4 Oct 2011 01:40:08 +0000 (12:10 +1030)]
net: fix tests for systems without IPv6 entries in /etc/hosts.
We fake up a dual IPv4/IPv6 response to localhost for testing, but it
assumed localhost6 or ip6-localhost entries. Fall back to "::1" which
should always work.
Rusty Russell [Tue, 4 Oct 2011 01:39:45 +0000 (12:09 +1030)]
foreach: make test more accurate, fix for 64-bit gcc 4.4.3
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 on x86_64 uses a different stack
offset for the second call to test_ptr_recursion(), meaning it sees
new iterators. Put it inside a loop to reduce the chance of that
happening.
Rusty Russell [Tue, 27 Sep 2011 06:28:43 +0000 (15:58 +0930)]
likely: use htable_type
Also general cleanups:
(1) Don't assume that strings are folded by the compiler.
(2) Implement likely_stats_reset().
(3) Return non-const string from likely_stats(), as caller must free it.
(4) Don't use struct info indirection (that was from when we used callbacks?)
(5) Close memory leak in run-debug.c
Rusty Russell [Tue, 27 Sep 2011 05:07:01 +0000 (14:37 +0930)]
htable: clean up interface, document htable_type better.
We change from htable_new()/htable_free() to htable_init/htable_clear.
We also change HTABLE_DEFINE_TYPE() to be the full name, without automatically
prepending htable_.
Rusty Russell [Tue, 20 Sep 2011 02:32:43 +0000 (12:02 +0930)]
tdb2: allow readonly changes even while holding locks.
This happens in SAMBA with the TDB_VERSION1, presumably due to a
read-only traverse nested inside a normal traverse (since it doesn't
occur without TDB_VERSION1).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Rusty Russell [Mon, 12 Sep 2011 04:51:40 +0000 (14:21 +0930)]
tdb2: add error conversion functions.
This clarifies the code a little, but also provides a more explicit
mechanism which can be used to debug error handling (by introducing
tdb_err_t and making it a pointer type).