]>
git.ozlabs.org Git - patchwork/log
Jeremy Kerr [Thu, 11 Sep 2008 06:42:26 +0000 (16:42 +1000)]
Don't just rely on random for UserPersonConfirmation keys
It looks like we're getting identical keys generated for confirmation
keys. Problem has been reported to django, but in the meantime, salt
with the user and email details, then sha1 to give the final key.
This requires an increase in the field size for key, migration script
included.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 11 Sep 2008 05:53:08 +0000 (15:53 +1000)]
Add HashField.construct() method
To construct a new hash object for the given algorithm. While we're at
it, clean up the hashlib-wrapping code.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 03:21:39 +0000 (13:21 +1000)]
xmlrpc: Fix Python 2.4 compatibility in _marshaled_dispatch
Based on an original patch from Nate Case <ncase@xes-inc.com>.
Python 24 doesn't accept encoding and allow_none fields for
xmlrpclib.dumps, so abstract this function at dispatcher init time.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 03:20:29 +0000 (13:20 +1000)]
Simplify hashlib behaviour in HashField
We only need to keep the size of the field required, not the
whole hashlib constructor
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:08:01 +0000 (12:08 +1000)]
Allow pwclient to accept patch hashes
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:03:50 +0000 (12:03 +1000)]
Make parser.py invokation a little more flexible
Add options to control output, allowing us to use the parser to
generate patch hashes.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:02:50 +0000 (12:02 +1000)]
Allow rehash for specific patches
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 01:21:19 +0000 (11:21 +1000)]
Use hex strings for hash values
Binary strings a too hard to manage in DB queries and XMLRPC methods,
as we get all kinds of encoding issues.
Change HashField to use a hex string, and add a migration script for db
updates. The patches should be rehashed after migration.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 08:19:19 +0000 (18:19 +1000)]
Add patch_get_by_hash method to XMLRPC interface
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 08:15:43 +0000 (18:15 +1000)]
Import hashlib in HashField.db_type
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 07:26:38 +0000 (17:26 +1000)]
Hook-up hashing infrastructure
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 06:00:58 +0000 (16:00 +1000)]
Move patchparser to patchwork.parser
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 05:34:59 +0000 (15:34 +1000)]
Remove unused parser.py file
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 04:47:09 +0000 (14:47 +1000)]
Add commit_ref field to patch page
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 04:27:27 +0000 (14:27 +1000)]
Re-save user profile after setting name
This means we get Person objects created with the correct name, rather
than the username at time of creation.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 03:05:51 +0000 (13:05 +1000)]
Pass Authorization headers in fastcgi application
By default, mod_fcgi doens't allow the Authorization header, so
enable -pass-header, and handle the different header name in the
xmlrpc view
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 01:15:03 +0000 (11:15 +1000)]
Fix user/username mismatch on pwclientrc template
... and add a comment to the auth section
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 00:54:05 +0000 (10:54 +1000)]
Use patchwork xmlrpc view in pwclientrc template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 00:51:17 +0000 (10:51 +1000)]
Fix broken pwclient link
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 00:46:47 +0000 (10:46 +1000)]
Rename pwclient.py to pwclient
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 23:39:08 +0000 (09:39 +1000)]
Add usage info for pwclient 'update' action
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 23:37:05 +0000 (09:37 +1000)]
Enable [auth] setion in pwclientrc template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 23:31:28 +0000 (09:31 +1000)]
Remove django_xmlrpc from about page.
Since we don't use it.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 23:28:33 +0000 (09:28 +1000)]
Add 'update' method to pwclient
This requires a new xmlrpc function, 'patch_set'. To do this, we
need HTTP Authentication support, which means changing to a custom
XMLRPC distpatcher that is aware of the Authorization: header.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 03:35:55 +0000 (13:35 +1000)]
Use 'in' rather than '.count()'
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 03:07:25 +0000 (13:07 +1000)]
Make pwclient visible thorugh site, and add .pwclientrc infrastructure
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 02:37:31 +0000 (12:37 +1000)]
Set content-disposition header for pwclientrc
So that browsers will save, rather than view.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 01:56:51 +0000 (11:56 +1000)]
Add pwclientrc configuration file sample for each project
This allows users to easily configure pwclient for a patchwork
instance.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 01:38:39 +0000 (11:38 +1000)]
Use config file for pwclient settings
Add a ConfigParser-style config file for patchwork settings, rather
than the environment. At present, only the XMLRPC URL and current
project are included.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 01:33:49 +0000 (11:33 +1000)]
xmlrpc: filter projects on linkname, not name
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 01:05:18 +0000 (11:05 +1000)]
Add credit for djagno-xmlrpc app
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 8 Sep 2008 00:40:21 +0000 (10:40 +1000)]
Only add /xmlrpc/ URL if ENABLE_XMLRPC is set.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 5 Sep 2008 19:27:31 +0000 (14:27 -0500)]
Add XML-RPC interface and command line client
Introduce a new XML-RPC Patchwork interface inspired by the SOAP
interface from the old Patchwork. The interface itself is fairly
lightweight and generic, and provides read-only access to a limited
subset of the Patchwork database, along with server-side search
and flexible filtering capabilities.
The command line client is modeled after the old one with some
additional filtering options.
The XML-RPC interface is disabled by default. You can enable it
by setting ENABLE_XMLRPC = True in local_settings.py
This feature uses the django-xmlrpc package available from
http://django-xmlrpc.googlecode.com.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 5 Sep 2008 14:45:36 +0000 (09:45 -0500)]
mod_python example configuration fixes
These fixes correct the example patchwork.mod_python.conf file to
actually work properly:
* Patchwork base directory needs to be in PythonPath so that
things like "apps.urls" will import
* Set DJANGO_SETTINGS_MODULE to "settings" instead of
"patchwork.settings" so that it can find the settings file to
import
* Use LocationMatch instead of Location in order for the pattern
matching to work (this was causing none of the images/stylesheets
to be found when using mod_python)
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 5 Sep 2008 07:39:23 +0000 (17:39 +1000)]
Show patch list checkboxes for all authenticated users
Although only some users can alter patches, others still need the
checkboxes to select patches to bundle.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 5 Sep 2008 06:12:21 +0000 (16:12 +1000)]
Use local settings module
This makes checkouts into a working patchwork site much easier.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 29 Aug 2008 22:25:46 +0000 (17:25 -0500)]
parsemail: Dynamically determine PATCHWORK_BASE
Remove hardcoded PATCHWORK_BASE in favor of determining it
relative to the script's location.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 5 Sep 2008 05:40:43 +0000 (15:40 +1000)]
Exclude packages tree from separate .gitignore file
'cos it says so in the top-level .gitignore.
Also, this means that the lib/packages/ dir will be included in a git
checkout, which is helpful.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 29 Aug 2008 22:25:47 +0000 (17:25 -0500)]
Add top-level .gitignore file
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 1 Sep 2008 03:56:09 +0000 (13:56 +1000)]
Add delegate column
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 1 Sep 2008 03:39:34 +0000 (13:39 +1000)]
Add content-disposition: attachment header to bundle download
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 07:48:41 +0000 (15:48 +0800)]
Remove redundant 'Patchwork' from titles in registration templates
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 07:23:49 +0000 (15:23 +0800)]
Use consistent icons for filter settings
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 04:10:18 +0000 (12:10 +0800)]
Remove duplicate "- Patchwork" from patch page titles
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 04:00:57 +0000 (12:00 +0800)]
Remove bottom margin from title
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 03:38:34 +0000 (11:38 +0800)]
Remove 'action: ' print output
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 03:31:10 +0000 (11:31 +0800)]
Use up/down arrows as sorting indicator
.. rather than a red heading, which implies an error.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 03:14:50 +0000 (11:14 +0800)]
Clean up stylesheet whitespace
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 22 Aug 2008 20:58:07 +0000 (15:58 -0500)]
parsemail.sh typo: Insert missing slash in path
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 22 Aug 2008 20:58:06 +0000 (15:58 -0500)]
Python 2.4 exception printing compatibility
Use str(ex) instead of ex.message for reporting exceptions
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 22 Aug 2008 20:58:05 +0000 (15:58 -0500)]
Support postgresql_psycopg2 DATABASE_ENGINE
Check for "postgresql*" rather than just "postgresql" in
HashField.db_type() so that postgresql_psycopg2 will work.
While we're here, raise an exception if the database engine is
unknown rather than silently not returning anything.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Sat, 23 Aug 2008 03:03:18 +0000 (11:03 +0800)]
In some places tabs are used instead of spaces for indentation,
even when other lines of a method are indented with spaces.
This gets rid of all tabs and uses spaces everywhere.
[Reworked to apply on newer code by Jeremy]
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 22 Aug 2008 20:58:03 +0000 (15:58 -0500)]
Add support for Python 2.4 email modules
Use email.MIMEText, email.Utils, and email.Header in the case
where importing the newer email.mime.text, email.utils, and
email.header modules failed.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Fri, 22 Aug 2008 20:58:02 +0000 (15:58 -0500)]
Eliminate hashlib requirement
If the hashlib module does not exist, use sha and md5 modules instead
to support Python 2.4. The hashlib module was added to Python 2.5.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 02:29:12 +0000 (10:29 +0800)]
Add simple help infrastructure, with an 'about' page.
We'll need the about page for adding attribution for included
components.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 02:25:43 +0000 (10:25 +0800)]
Use self.fields[field] rather than self.field when iterating form fields
This way, we included the delegate field added in the
MultiplePatchForm's constructor.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 23 Aug 2008 00:47:16 +0000 (08:47 +0800)]
Patchform.delegate isn't required
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 07:17:05 +0000 (15:17 +0800)]
Add padding before each project in 'other projects' lists
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 07:09:42 +0000 (15:09 +0800)]
Tone down acked-by and signed-off-by colours a little
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 06:17:44 +0000 (14:17 +0800)]
Zebra-stripe the patch list
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 03:17:59 +0000 (11:17 +0800)]
Use DEFAULT_FROM_EMAIL rather than PATCHWORK_FROM_EMAIL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 03:02:04 +0000 (11:02 +0800)]
Add DB permissions for registration app
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 02:42:05 +0000 (10:42 +0800)]
Document dependency on django-registration
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 22 Aug 2008 02:41:25 +0000 (10:41 +0800)]
Use django-registration infrastructure
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 10:15:19 +0000 (18:15 +0800)]
No help for now.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:45:00 +0000 (17:45 +0800)]
Patchwork Beta 1.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:25:35 +0000 (17:25 +0800)]
Add project argument to set_bundle
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:24:01 +0000 (17:24 +0800)]
Add project argument to set_patches
MultiplePatchForm needs a project, so pass one down.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:20:45 +0000 (17:20 +0800)]
Remove unused and incomplete bundle.set_patches view
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:18:22 +0000 (17:18 +0800)]
Add more details to installation procedure
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 09:15:40 +0000 (17:15 +0800)]
Fix NoReverseMatch in patch template
Jeremy Kerr [Thu, 21 Aug 2008 09:08:23 +0000 (17:08 +0800)]
Get parsemail scripts going
A couple of fixes, plus required permissions in the grant-all script.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 08:44:00 +0000 (16:44 +0800)]
Remove beta link text from user-link template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 08:24:47 +0000 (16:24 +0800)]
Add Users and Sites objects to admin site
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 08:11:20 +0000 (16:11 +0800)]
Use new django admin infrastructure
Also, we don't need to expose every object.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 07:19:48 +0000 (15:19 +0800)]
newforms is just 'forms' now.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 05:41:10 +0000 (13:41 +0800)]
Implement confirmation emails.
To do this, we need to allow sucessive requests for the same
confirmation URL.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 02:11:33 +0000 (10:11 +0800)]
Clean style.css
Remove crappy whitespace, and reorder.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 02:06:33 +0000 (10:06 +0800)]
Make submitter filter AJAX work in Firefox
.options can't be set in Firefox.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 01:51:40 +0000 (09:51 +0800)]
Add appropriate javascrip variable decalrations
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 01:49:58 +0000 (09:49 +0800)]
Fix invalid border style
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 21 Aug 2008 01:38:06 +0000 (09:38 +0800)]
Inital commit
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>