From: Jeremy Kerr <jk@ozlabs.org>
Date: Tue, 19 Apr 2011 05:09:36 +0000 (+0800)
Subject: Order: always set Order.order
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=fa7c42111829420729d7f024a694196aefb299b4;p=patchwork

Order: always set Order.order

If we create an Order objecty with editable = True, we don't initialise
self.order, leading to testsuite failures with django-1.3.

This change always initialises Order.order (and Order.reversed), so we
don't exit the constructor without these initalised.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---

diff --git a/apps/patchwork/utils.py b/apps/patchwork/utils.py
index e41ffb6..5a8e4c0 100644
--- a/apps/patchwork/utils.py
+++ b/apps/patchwork/utils.py
@@ -49,12 +49,12 @@ class Order(object):
     def __init__(self, str = None, editable = False):
         self.reversed = False
         self.editable = editable
+        (self.order, self.reversed) = self.default_order
 
         if self.editable:
             return
 
         if str is None or str == '':
-            (self.order, self.reversed) = self.default_order
             return
 
         reversed = False
@@ -63,7 +63,6 @@ class Order(object):
             reversed = True
 
         if str not in self.order_map.keys():
-            (self.order, self.reversed) = self.default_order
             return
 
         self.order = str