From: Pali Rohár <pali@kernel.org>
Date: Wed, 30 Dec 2020 10:04:36 +0000 (+0100)
Subject: Fix indicating failure in Linux get_if_hwaddr() function
X-Git-Tag: ppp-2.4.9~35^2
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=9793fd2e7762623ef4bbaaa1a16dbedd10659599;p=ppp.git

Fix indicating failure in Linux get_if_hwaddr() function

This function should return negative value on error.

Signed-off-by: Pali Rohár <pali@kernel.org>
---

diff --git a/pppd/sys-linux.c b/pppd/sys-linux.c
index 6e14238..fd758da 100644
--- a/pppd/sys-linux.c
+++ b/pppd/sys-linux.c
@@ -2087,7 +2087,7 @@ get_if_hwaddr(u_char *addr, char *name)
 
 	sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
 	if (sock_fd < 0)
-		return 0;
+		return -1;
 	memset(&ifreq.ifr_hwaddr, 0, sizeof(struct sockaddr));
 	strlcpy(ifreq.ifr_name, name, sizeof(ifreq.ifr_name));
 	ret = ioctl(sock_fd, SIOCGIFHWADDR, &ifreq);