From: Philip A. Prindeville <philipp@redfish-solutions.com>
Date: Sat, 20 Dec 2014 00:52:58 +0000 (-0700)
Subject: pppd: Fix sign-extension when displaying bytes in octal
X-Git-Tag: ppp-2.4.8~48^2
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=5e8c3cb256a7e86e3572a82a75d51c6850efdbdc;hp=-c;p=ppp.git

pppd: Fix sign-extension when displaying bytes in octal

print_string() displays characters as \\%.03o but without first
casting it from "char" to "unsigned char" so it gets sign-extended
to an int. This causes output like \37777777630 instead of \230.

Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
---

5e8c3cb256a7e86e3572a82a75d51c6850efdbdc
diff --git a/pppd/utils.c b/pppd/utils.c
index 29bf970..3ac1b60 100644
--- a/pppd/utils.c
+++ b/pppd/utils.c
@@ -625,7 +625,7 @@ print_string(p, len, printer, arg)
 		printer(arg, "\\t");
 		break;
 	    default:
-		printer(arg, "\\%.3o", c);
+		printer(arg, "\\%.3o", (unsigned char) c);
 	    }
 	}
     }