From: Eivind Næss <eivnaes@yahoo.com>
Date: Thu, 23 Sep 2021 14:40:01 +0000 (-0700)
Subject: Fixing signed vs. unsigned char* warnings in avpair.c
X-Git-Tag: ppp-2.5.0~56^2~8
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=5c62101f3ba79a98b2651cfa4704a0ef1ceecdfb;p=ppp.git

Fixing signed vs. unsigned char* warnings in avpair.c

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
---

diff --git a/pppd/plugins/radius/avpair.c b/pppd/plugins/radius/avpair.c
index d548b47..0dc9a85 100644
--- a/pppd/plugins/radius/avpair.c
+++ b/pppd/plugins/radius/avpair.c
@@ -76,7 +76,7 @@ int rc_avpair_assign (VALUE_PAIR *vp, void *pval, int len)
 				vp->strvalue[len] = '\0';
 				vp->lvalue = len;
 			} else {
-			strncpy (vp->strvalue, (char *) pval, AUTH_STRING_LEN);
+			strncpy ((char*) vp->strvalue, (char *) pval, AUTH_STRING_LEN);
 			vp->lvalue = strlen((char *) pval);
 			}
 
@@ -161,7 +161,7 @@ VALUE_PAIR *rc_avpair_gen (AUTH_HDR *auth)
 	DICT_ATTR      *attr;
 	VALUE_PAIR     *vp;
 	VALUE_PAIR     *pair;
-	unsigned char   hex[3];		/* For hex string conversion. */
+	char            hex[3];		/* For hex string conversion. */
 	char            buffer[512];
 
 	/*
@@ -600,7 +600,7 @@ int rc_avpair_parse (char *buffer, VALUE_PAIR **first_pair)
 			{
 
 			    case PW_TYPE_STRING:
-				strcpy (pair->strvalue, valstr);
+				strcpy ((char*) pair->strvalue, valstr);
 				pair->lvalue = strlen(valstr);
 				break;
 
@@ -725,7 +725,7 @@ int rc_avpair_tostr (VALUE_PAIR *pair, char *name, int ln, char *value, int lv)
 			}
 			else
 			{
-				strncat(value, ptr, 1);
+				strncat(value, (char*) ptr, 1);
 				lv--;
 				if (lv < 0) break;
 			}