From: Paul Mackerras <paulus@samba.org>
Date: Mon, 11 Mar 2013 08:30:21 +0000 (+1100)
Subject: pppd: Default exit status to EXIT_CONNECT_FAILED during connection phase
X-Git-Tag: ppp-2.4.7~23
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=225361d64ae737afdc8cb57579a2f33525461bc9;p=ppp.git

pppd: Default exit status to EXIT_CONNECT_FAILED during connection phase

The rp-pppoe plugin doesn't set the exit status in its connect
function, resulting in pppd exiting with a status of EXIT_OK (0)
if rp-pppoe fails to connect.  This fixes the problem for rp-pppoe
and any other plugins that don't set the exit status explicitly
by making the status default to EXIT_CONNECT_FAILED if the channel's
connect function fails.

Reported-by: Peter Warasin <peter@endian.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/pppd/auth.c b/pppd/auth.c
index 2f81283..4271af6 100644
--- a/pppd/auth.c
+++ b/pppd/auth.c
@@ -553,6 +553,7 @@ link_required(unit)
 void start_link(unit)
     int unit;
 {
+    status = EXIT_CONNECT_FAILED;
     new_phase(PHASE_SERIALCONN);
 
     hungup = 0;