From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Sun, 19 Jul 2020 11:43:39 +0000 (+0200)
Subject: pppd: Fix the default value for ipv6cp-accept-local to false
X-Git-Tag: ppp-2.4.9~55^2~1
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=0678d3bf69116af58b00fbc64bd4185acb4d5c37;p=ppp.git

pppd: Fix the default value for ipv6cp-accept-local to false

The ipv6cp-accept-local option was supposed to enable it, but it is
already enabled by default, with no way to disable it.

For coherency with IPv4 and IPX, this disables ipv6cp-accept-local by
default, and the option can be used to enable it.

This also enables it automatically when the local id is not
specified, in coherency with IPv4 and IPX, and as the documentation was
saying.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---

diff --git a/pppd/ipv6cp.c b/pppd/ipv6cp.c
index bda91e9..47e3422 100644
--- a/pppd/ipv6cp.c
+++ b/pppd/ipv6cp.c
@@ -443,7 +443,7 @@ ipv6cp_init(unit)
     memset(wo, 0, sizeof(*wo));
     memset(ao, 0, sizeof(*ao));
 
-    wo->accept_local = 1;
+    wo->accept_local = 0;
     wo->neg_ifaceid = 1;
     ao->neg_ifaceid = 1;
 
@@ -544,6 +544,7 @@ ipv6cp_resetci(f)
     wo->req_ifaceid = wo->neg_ifaceid && ipv6cp_allowoptions[f->unit].neg_ifaceid;
     
     if (!wo->opt_local) {
+	wo->accept_local = 1;
 	eui64_magic_nz(wo->ourid);
     }