From: Eivind Næss <eivnaes@yahoo.com>
Date: Mon, 20 Sep 2021 17:01:55 +0000 (-0700)
Subject: Fixing GCC compile warning with unused result from setgid/setuid.
X-Git-Tag: ppp-2.5.0~56^2~16
X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;h=05f088613bebc9fb743c309e9b9390d376387f1c;hp=69c516a36ddeac5fd41d4ef8879f16fd5db88266;p=ppp.git

Fixing GCC compile warning with unused result from setgid/setuid.

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
---

diff --git a/pppd/plugins/passprompt.c b/pppd/plugins/passprompt.c
index dae3268..743c087 100644
--- a/pppd/plugins/passprompt.c
+++ b/pppd/plugins/passprompt.c
@@ -35,7 +35,7 @@ static int promptpass(char *user, char *passwd)
 {
     int p[2];
     pid_t kid;
-    int readgood, wstat;
+    int readgood, wstat, ret;
     ssize_t red;
 
     if (promptprog_refused || promptprog[0] == 0 || access(promptprog, X_OK) < 0)
@@ -60,8 +60,14 @@ static int promptpass(char *user, char *passwd)
 	sys_close();
 	closelog();
 	close(p[0]);
-	seteuid(getuid());
-	setegid(getgid());
+	ret = seteuid(getuid());
+	if (ret != 0) {
+		warn("Couldn't set effective user id");
+	}
+	ret = setegid(getgid());
+	if (ret != 0) {
+		warn("Couldn't set effective user id");
+	}
 	argv[0] = promptprog;
 	argv[1] = user;
 	argv[2] = remote_name;