From: Rusty Russell Date: Mon, 9 Jan 2023 02:22:22 +0000 (+1030) Subject: stringbuilder: avoid overwriting end of buffer with nul terminator. X-Git-Url: http://git.ozlabs.org/?a=commitdiff_plain;ds=sidebyside;h=1ee3028a58e7c4a78491dd07a97feaecbdf5731f;p=ccan stringbuilder: avoid overwriting end of buffer with nul terminator. Signed-off-by: Rusty Russell --- diff --git a/ccan/stringbuilder/stringbuilder.c b/ccan/stringbuilder/stringbuilder.c index d34de811..8eb4ab42 100644 --- a/ccan/stringbuilder/stringbuilder.c +++ b/ccan/stringbuilder/stringbuilder.c @@ -22,7 +22,8 @@ static int stringbuilder_cpy( if (*str != s) { if (!s_len) s_len = strlen(s); - if (s_len > *str_sz) + /* Include nul term! */ + if (s_len >= *str_sz) return EMSGSIZE; strcpy(*str, s); }