X-Git-Url: http://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Fhash_if.c;h=13750e9451629b83b8cf3bce766eeb37bdcc85d3;hb=932d65dd6537250e617516749f03a00fea3b34f6;hp=3eefd1fdadf51f00e8689b8cb806513c3d8015b8;hpb=9450cb3c1dff76e09305d18687291bce4221e9b6;p=ccan

diff --git a/tools/ccanlint/tests/hash_if.c b/tools/ccanlint/tests/hash_if.c
index 3eefd1fd..13750e94 100644
--- a/tools/ccanlint/tests/hash_if.c
+++ b/tools/ccanlint/tests/hash_if.c
@@ -17,14 +17,16 @@
 #include <ctype.h>
 
 static void check_hash_if(struct manifest *m,
-				   bool keep,
-				   unsigned int *timeleft, struct score *score)
+			  unsigned int *timeleft, struct score *score)
 {
 	struct list_head *list;
 	const char *explanation =
 	"\n\t(#if works like #ifdef, but with gcc's -Wundef, we can detect\n"
 	"\tmistyped or unknown configuration options)";
 
+	/* We don't fail ccanlint for this. */ 
+	score->pass = true;
+
 	foreach_ptr(list, &m->c_files, &m->h_files,
 		    &m->run_tests, &m->api_tests,
 		    &m->compile_ok_tests, &m->compile_fail_tests,
@@ -60,7 +62,6 @@ static void check_hash_if(struct manifest *m,
 	}
 
 	if (!score->error) {
-		score->pass = true;
 		score->score = score->total;
 	}
 }
@@ -69,7 +70,7 @@ struct ccanlint hash_if = {
 	.key = "hash_if",
 	.name = "Features are checked with #if not #ifdef",
 	.check = check_hash_if,
-	.needs = ""
+	.needs = "info_exists"
 };
 
 REGISTER_TEST(hash_if);