X-Git-Url: http://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Fexamples_exist.c;h=7e9dd97cc8afa379ba227108e3fd0354c80b9aff;hb=0621cac3bf1b5cf4c90de56e0e43b0acde0c94f1;hp=2091f67f0f97c82218b57d77a380ee3528eedc4f;hpb=7bb7cd58c2d9df126dd6072e5f3bec1eb4dc916b;p=ccan

diff --git a/tools/ccanlint/tests/examples_exist.c b/tools/ccanlint/tests/examples_exist.c
index 2091f67f..7e9dd97c 100644
--- a/tools/ccanlint/tests/examples_exist.c
+++ b/tools/ccanlint/tests/examples_exist.c
@@ -2,6 +2,7 @@
 #include <tools/tools.h>
 #include <ccan/talloc/talloc.h>
 #include <ccan/str/str.h>
+#include <ccan/cast/cast.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
@@ -16,7 +17,6 @@
 
 /* Creates and adds an example file. */
 static char *add_example(struct manifest *m, struct ccan_file *source,
-			 bool keep,
 			 struct doc_section *example)
 {
 	char *name;
@@ -33,7 +33,7 @@ static char *add_example(struct manifest *m, struct ccan_file *source,
 	while (strchr(name, ' '))
 		*strchr(name, ' ') = '_';
 
-	name = maybe_temp_file(m, ".c", keep, name);
+	name = temp_file(m, ".c", name);
 	f = new_ccan_file(m, talloc_dirname(m, name), talloc_basename(m, name));
 	talloc_steal(f, name);
 	list_add_tail(&m->examples, &f->list);
@@ -48,7 +48,8 @@ static char *add_example(struct manifest *m, struct ccan_file *source,
 		    != strlen(example->lines[i])
 		    || write(fd, "\n", 1) != 1) {
 			close(fd);
-			return "Failure writing to temporary file";
+			return cast_const(char *,
+					  "Failure writing to temporary file");
 		}
 	}
 	close(fd);
@@ -57,7 +58,6 @@ static char *add_example(struct manifest *m, struct ccan_file *source,
 
 /* FIXME: We should have one example per function in header. */
 static void extract_examples(struct manifest *m,
-			     bool keep,
 			     unsigned int *timeleft,
 			     struct score *score)
 {
@@ -68,7 +68,7 @@ static void extract_examples(struct manifest *m,
 	score->total = 2;
 	list_for_each(get_ccan_file_docs(m->info_file), d, list) {
 		if (streq(d->type, "example")) {
-			score->error = add_example(m, m->info_file, keep, d);
+			score->error = add_example(m, m->info_file, d);
 			if (score->error)
 				return;
 			have_info_example = true;
@@ -84,7 +84,7 @@ static void extract_examples(struct manifest *m,
 		mainh = f;
 		list_for_each(get_ccan_file_docs(f), d, list) {
 			if (streq(d->type, "example")) {
-				score->error = add_example(m, f, keep, d);
+				score->error = add_example(m, f, d);
 				if (score->error)
 					return;
 				have_header_example = true;
@@ -92,9 +92,10 @@ static void extract_examples(struct manifest *m,
 		}
 	}
 
+	/* We don't fail ccanlint for this. */
+	score->pass = true;
 	if (have_info_example && have_header_example) {
 		score->score = score->total;
-		score->pass = true;
 		return;
 	}
 
@@ -104,8 +105,6 @@ static void extract_examples(struct manifest *m,
 		score_file_error(score, mainh, 0, "No Example: section");
 
 	score->score = have_info_example + have_header_example;
-	/* We pass if we find any example. */
-	score->pass = score->score != 0;
 }
 
 struct ccanlint examples_exist = {