X-Git-Url: http://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Fccanlint.c;h=e2a687e06c410751996235e82192405726baa654;hb=f1f32a2ff565d98dd41326342eb05efc12fdb886;hp=158195cbdef04adf4c6ca1323ccc68c3862b1f1b;hpb=0b98a031eb38433fb774cd9dacc318e8ee60e56d;p=ccan diff --git a/tools/ccanlint/ccanlint.c b/tools/ccanlint/ccanlint.c index 158195cb..e2a687e0 100644 --- a/tools/ccanlint/ccanlint.c +++ b/tools/ccanlint/ccanlint.c @@ -35,12 +35,10 @@ #include #include -struct ccanlint_map { - STRMAP_MEMBERS(struct ccanlint *); -}; +typedef STRMAP(struct ccanlint *) ccanlint_map_t; int verbose = 0; -static struct ccanlint_map tests; +static ccanlint_map_t tests; bool safe_mode = false; bool keep_results = false; bool non_ccan_deps = false; @@ -273,7 +271,7 @@ static bool init_deps(const char *member, struct ccanlint *c, void *unused) } static bool check_names(const char *member, struct ccanlint *c, - struct ccanlint_map *names) + ccanlint_map_t *names) { if (!strmap_add(names, c->name, c)) err(1, "Duplicate name %s", c->name); @@ -282,7 +280,7 @@ static bool check_names(const char *member, struct ccanlint *c, static void init_tests(void) { - struct ccanlint_map names; + ccanlint_map_t names; struct ccanlint **table; size_t i, num; @@ -579,6 +577,8 @@ static bool run_tests(struct dgraph_node *all, if (deps_fail_ignore && non_ccan_deps && build_failed) { comment = " (missing non-ccan dependencies?)"; run.pass = true; + } else if (!run.pass) { + comment = " FAIL!"; } printf("%sTotal score: %u/%u%s\n", prefix, run.score, run.total, comment);