X-Git-Url: http://git.ozlabs.org/?a=blobdiff_plain;f=discover%2Fgrub2%2Fbuiltins.c;h=8bff7328108479f1b95dbd2d3196cdeada238808;hb=e544283809454252c2c2d3148492362ad10643ba;hp=71ae61a3ae97118ed63e7f30303e2c4d4c09dd7c;hpb=fcbb46482c413192756ce865a7336c5638fda6d3;p=petitboot

diff --git a/discover/grub2/builtins.c b/discover/grub2/builtins.c
index 71ae61a..8bff732 100644
--- a/discover/grub2/builtins.c
+++ b/discover/grub2/builtins.c
@@ -5,8 +5,9 @@
 #include <log/log.h>
 #include <types/types.h>
 #include <talloc/talloc.h>
-#include <array-size/array-size.h>
+#include <util/util.h>
 
+#include "discover/parser.h"
 #include "grub2.h"
 
 
@@ -123,7 +124,62 @@ static int builtin_search(struct grub2_script *script,
 	return 0;
 }
 
-static bool builtin_test_op(int argc, char **argv, int *consumed)
+/* Note that GRUB does not follow symlinks in evaluating all file
+ * tests but -s, unlike below. However, it seems like a bad idea to
+ * emulate GRUB's behavior (e.g., it would take extra work), so we
+ * implement the behavior that coreutils' test binary has. */
+static bool builtin_test_op_file(struct grub2_script *script, char op,
+		const char *file)
+{
+	bool result;
+	int rc;
+	struct stat statbuf;
+
+	rc = parser_stat_path(script->ctx, script->ctx->device,
+			file, &statbuf);
+	if (rc)
+		return false;
+
+	switch (op) {
+	case 's':
+		/* -s: return true if file exists and has non-zero size */
+		result = statbuf.st_size > 0;
+		break;
+	case 'f':
+		/* -f: return true if file exists and is not a directory. This is
+		 * different than the behavior of "test", but is what GRUB does
+		 * (though note as above that we follow symlinks unlike GRUB). */
+		result = !S_ISDIR(statbuf.st_mode);
+		break;
+	default:
+		result = false;
+
+	}
+
+	return result;
+}
+
+/* See comment at builtin_test_op_file for differences between how
+ * GRUB implements file tests versus Petitboot's GRUB parser. */
+static bool builtin_test_op_dir(struct grub2_script *script, char op,
+		const char *dir)
+{
+	int rc;
+	struct stat statbuf;
+
+	if (op != 'd')
+		return false;
+
+	rc = parser_stat_path(script->ctx, script->ctx->device, dir, &statbuf);
+	if (rc) {
+		return false;
+	}
+
+	return S_ISDIR(statbuf.st_mode);
+}
+
+static bool builtin_test_op(struct grub2_script *script,
+		int argc, char **argv, int *consumed)
 {
 	char *op;
 
@@ -171,10 +227,14 @@ static bool builtin_test_op(int argc, char **argv, int *consumed)
 			return strlen(a1) != 0;
 		}
 
-		/* todo: implement file checks */
 		if (!strcmp(op, "-s") || !strcmp(op, "-f")) {
 			*consumed = 2;
-			return false;
+			return builtin_test_op_file(script, op[1], a1);
+		}
+
+		if (!strcmp(op, "-d")) {
+			*consumed = 2;
+			return builtin_test_op_dir(script, op[1], a1);
 		}
 	}
 
@@ -183,7 +243,7 @@ static bool builtin_test_op(int argc, char **argv, int *consumed)
 	return strlen(op) > 0;
 }
 
-static int builtin_test(struct grub2_script *script __attribute__((unused)),
+static int builtin_test(struct grub2_script *script,
 		void *data __attribute__((unused)),
 		int argc, char *argv[])
 {
@@ -222,7 +282,7 @@ static int builtin_test(struct grub2_script *script __attribute__((unused)),
 			continue;
 		}
 
-		rc = builtin_test_op(argc, argv, &consumed);
+		rc = builtin_test_op(script, argc, argv, &consumed);
 		if (not) {
 			rc = !rc;
 			not = false;
@@ -259,6 +319,10 @@ static int builtin_nop(struct grub2_script *script __attribute__((unused)),
 extern int builtin_load_env(struct grub2_script *script,
 		void *data __attribute__((unused)),
 		int argc, char *argv[]);
+int builtin_save_env(struct grub2_script *script,
+		void *data __attribute__((unused)),
+		int argc, char *argv[]);
+
 
 static struct {
 	const char *name;
@@ -304,6 +368,10 @@ static struct {
 		.name = "load_env",
 		.fn = builtin_load_env,
 	},
+	{
+		.name = "save_env",
+		.fn = builtin_save_env,
+	},
 };
 
 static const char *nops[] = {