X-Git-Url: http://git.ozlabs.org/?a=blobdiff_plain;f=ccan%2Fio%2Fio.c;h=4c73b62455693f6ae5c633c910921583cd3a5089;hb=36c52c260ed076d36a308dc4ea755f965abf0629;hp=b74520444353761451529af0d0467522293f2686;hpb=490b63852f281f0d72eb6f6dfa5e0dce36bcbe0d;p=ccan diff --git a/ccan/io/io.c b/ccan/io/io.c index b7452044..4c73b624 100644 --- a/ccan/io/io.c +++ b/ccan/io/io.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include @@ -25,8 +24,6 @@ bool io_plan_nodebug; struct io_conn *current; /* User-defined function to select which connection(s) to debug. */ bool (*io_debug_conn)(struct io_conn *conn); -/* Set when we wake up an connection we are debugging. */ -bool io_debug_wakeup; struct io_plan io_debug(struct io_plan plan) { @@ -37,21 +34,12 @@ struct io_plan io_debug(struct io_plan plan) return plan; } - if (!current || !doing_debug_on(current)) { - if (!io_debug_wakeup) - return plan; - } + if (!current || !doing_debug_on(current)) + return plan; - io_debug_wakeup = false; current->plan = plan; backend_plan_changed(current); - /* If it closed, close duplex. */ - if (!current->plan.next && current->duplex) { - current->duplex->plan = io_close_(); - backend_plan_changed(current->duplex); - } - /* Call back into the loop immediately. */ io_loop_return = do_io_loop(&ready); @@ -75,7 +63,7 @@ struct io_plan io_debug(struct io_plan plan) /* Return a do-nothing plan, so backend_plan_changed in * io_ready doesn't do anything (it's already been called). */ - return io_idle_(); + return io_wait_(NULL, (void *)1, NULL); } int io_debug_io(int ret) @@ -100,6 +88,10 @@ int io_debug_io(int ret) case 1: /* Done: get next plan. */ if (timeout_active(conn)) backend_del_timeout(conn); + /* In case they call io_duplex, clear our poll flags so + * both sides don't seem to be both doing read or write + * (See assert(!mask || pfd->events != mask) in poll.c) */ + conn->plan.pollflag = 0; conn->plan.next(conn, conn->plan.next_arg); break; default: @@ -110,22 +102,12 @@ int io_debug_io(int ret) return 2; } -static void debug_io_wake(struct io_conn *conn) -{ - /* We want linear if we wake a debugged connection, too. */ - if (io_debug_conn && io_debug_conn(conn)) - io_debug_wakeup = true; -} - /* Counterpart to io_plan_no_debug(), called in macros in io.h */ static void io_plan_debug_again(void) { io_plan_nodebug = false; } #else -static void debug_io_wake(struct io_conn *conn) -{ -} static void io_plan_debug_again(void) { } @@ -234,6 +216,26 @@ bool io_timeout_(struct io_conn *conn, struct timespec ts, return true; } +/* Always done: call the next thing. */ +static int do_always(int fd, struct io_plan *plan) +{ + return 1; +} + +struct io_plan io_always_(struct io_plan (*cb)(struct io_conn *, void *), + void *arg) +{ + struct io_plan plan; + + assert(cb); + plan.io = do_always; + plan.next = cb; + plan.next_arg = arg; + plan.pollflag = POLLALWAYS; + + return plan; +} + /* Returns true if we're finished. */ static int do_write(int fd, struct io_plan *plan) { @@ -254,6 +256,10 @@ struct io_plan io_write_(const void *data, size_t len, struct io_plan plan; assert(cb); + + if (len == 0) + return io_always_(cb, arg); + plan.u1.const_vp = data; plan.u2.s = len; plan.io = do_write; @@ -283,11 +289,16 @@ struct io_plan io_read_(void *data, size_t len, struct io_plan plan; assert(cb); + + if (len == 0) + return io_always_(cb, arg); + plan.u1.cp = data; plan.u2.s = len; plan.io = do_read; plan.next = cb; plan.next_arg = arg; + plan.pollflag = POLLIN; return plan; @@ -311,6 +322,10 @@ struct io_plan io_read_partial_(void *data, size_t *len, struct io_plan plan; assert(cb); + + if (*len == 0) + return io_always_(cb, arg); + plan.u1.cp = data; plan.u2.vp = len; plan.io = do_read_partial; @@ -339,6 +354,10 @@ struct io_plan io_write_partial_(const void *data, size_t *len, struct io_plan plan; assert(cb); + + if (*len == 0) + return io_always_(cb, arg); + plan.u1.const_vp = data; plan.u2.vp = len; plan.io = do_write_partial; @@ -402,36 +421,34 @@ struct io_plan io_connect_(int fd, const struct addrinfo *addr, return plan; } -struct io_plan io_idle_(void) +struct io_plan io_wait_(const void *wait, + struct io_plan (*cb)(struct io_conn *, void*), + void *arg) { struct io_plan plan; + assert(cb); plan.pollflag = 0; plan.io = NULL; - /* Never called (overridden by io_wake), but NULL means closing */ - plan.next = (void *)io_idle_; + plan.next = cb; + plan.next_arg = arg; + + plan.u1.const_vp = wait; return plan; } -void io_wake_(struct io_conn *conn, struct io_plan plan) - +void io_wake(const void *wait) { - io_plan_debug_again(); - - /* It might be closing, but we haven't called its finish() yet. */ - if (!conn->plan.next) - return; - /* It was idle, right? */ - assert(!conn->plan.io); - conn->plan = plan; - backend_plan_changed(conn); - - debug_io_wake(conn); + backend_wait_changed(wait); } void io_ready(struct io_conn *conn) { + /* Beware io_close_other! */ + if (!conn->plan.next) + return; + set_current(conn); switch (conn->plan.io(conn->fd.fd, &conn->plan)) { case -1: /* Failure means a new plan: close up. */ @@ -443,18 +460,14 @@ void io_ready(struct io_conn *conn) case 1: /* Done: get next plan. */ if (timeout_active(conn)) backend_del_timeout(conn); + /* In case they call io_duplex, clear our poll flags so + * both sides don't seem to be both doing read or write + * (See assert(!mask || pfd->events != mask) in poll.c) */ + conn->plan.pollflag = 0; conn->plan = conn->plan.next(conn, conn->plan.next_arg); backend_plan_changed(conn); } set_current(NULL); - - /* If it closed, close duplex. */ - if (!conn->plan.next && conn->duplex) { - set_current(conn->duplex); - conn->duplex->plan = io_close(); - backend_plan_changed(conn->duplex); - set_current(NULL); - } } /* Close the connection, we're done. */ @@ -475,6 +488,15 @@ struct io_plan io_close_cb(struct io_conn *conn, void *arg) return io_close(); } +void io_close_other(struct io_conn *conn) +{ + /* Don't close if already closing! */ + if (conn->plan.next) { + conn->plan = io_close_(); + backend_plan_changed(conn); + } +} + /* Exit the loop, returning this (non-NULL) arg. */ struct io_plan io_break_(void *ret, struct io_plan plan) { @@ -486,6 +508,16 @@ struct io_plan io_break_(void *ret, struct io_plan plan) return plan; } +static struct io_plan io_never_called(struct io_conn *conn, void *arg) +{ + abort(); +} + +struct io_plan io_never(void) +{ + return io_always_(io_never_called, NULL); +} + int io_conn_fd(const struct io_conn *conn) { return conn->fd.fd;